Skip to content

chore(openai): propagate needs_approval field for tools#110

Merged
shijiesheng merged 2 commits into
cadence-workflow:mainfrom
shijiesheng:contrib-openai-tool-with-approval
May 19, 2026
Merged

chore(openai): propagate needs_approval field for tools#110
shijiesheng merged 2 commits into
cadence-workflow:mainfrom
shijiesheng:contrib-openai-tool-with-approval

Conversation

@shijiesheng
Copy link
Copy Markdown
Member

What changed?

  • in mappers between cadence tools and tools, propagate needs_approval

Why?

needed for tool guard

How did you test it?

Potential risks

Release notes

Documentation Changes

Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
@shijiesheng shijiesheng force-pushed the contrib-openai-tool-with-approval branch from d95c62f to 37ec9f4 Compare May 19, 2026 22:10
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 19, 2026

CI failed: The integration test `test_update_spec` failed due to a transient RPC error caused by the Cadence scheduler workflow entering a 'CONTINUED_AS_NEW' state during test execution.

Overview

One integration test failed during the CI run. The failure appears to be a transient issue with the test environment or the Cadence server's handling of scheduled workflows, rather than a direct consequence of the PR changes.

Failures

test_update_spec failure (confidence: medium)

  • Type: flaky_test
  • Affected jobs: 76847636121
  • Related to change: no
  • Root cause: The test encountered a CadenceRpcError because the scheduler workflow terminated with a CONTINUED_AS_NEW status while the test was attempting to update the schedule, indicating a potential race condition or state mismatch in the integration environment.
  • Suggested fix: Verify the stability of this test on the main branch. Since this is an integration-level environmental issue, consider increasing the test timeout or adding retry logic if the test continues to flake.

Summary

  • Change-related failures: 0
  • Infrastructure/flaky failures: 1 (integration test flakiness)
  • Recommended action: Confirm if this test is flaky on the main branch. If it is known to be flaky, it should be addressed independently of this PR. No changes to the needs_approval implementation are required based on this failure.
Code Review ✅ Approved

Propagates the needs_approval field within tool mappers to enable integration with tool guard. No issues found.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cadence/contrib/openai/cadence_tool.py 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
cadence/contrib/openai/cadence_tool.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shijiesheng shijiesheng merged commit 2b62a91 into cadence-workflow:main May 19, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants