Add embedded playgrounds on handle and handle_path#480
Open
ProfessorLogout wants to merge 3 commits intocaddyserver:masterfrom
Open
Add embedded playgrounds on handle and handle_path#480ProfessorLogout wants to merge 3 commits intocaddyserver:masterfrom
ProfessorLogout wants to merge 3 commits intocaddyserver:masterfrom
Conversation
Member
|
Very cool! I'm excited to kick this around a bit. (Sorry, been busy with some things lately.) This is on my radar to circle back to soon :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @mholt and team,
as discussed I took a stab at adding tech playground embedded playgrounds as we discussed in chat.
I've added it two slightly different ways:
handle_path: Embedded into one of the exampleshandle: Added a separate header "Playground" after the examples, building on it to make it more useful as a playgroundI did not do any kind of styling so far, the element works mostly OK just with your existing styles.
If we decide to do this as a feature in the docs I would like to take some time to polish things with a bit of custom CSS and add proper styling for the output.
headless.min.jsis taken from this projects releases.I'm happy to take care of updates and related testing in the future.
Looking forward to any feedback you want to share!