Skip to content

chore(deps): update dependency brace-expansion@2 to v5 [security] #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cachekit-renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency brace-expansion@2 to v5 [security] #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ minimumReleaseAge: 1440
# fix. Version-scoped so future releases of the package still age-gate.
# Safe to delete from 2026-07-30 (2.1.3 clears the window 2026-07-29 ~10:17 UTC).
minimumReleaseAgeExclude:
- 'brace-expansion@2.1.3'
# Renovate security update: brace-expansion@5.0.12
- 'brace-expansion@2.1.3 || 5.0.12'
# Renovate security update: pnpm@11.11.0
- pnpm@11.11.0
# Renovate security update: vitest@4.1.11
Expand Down Expand Up @@ -72,7 +73,7 @@ overrides:
picomatch: '>=4.0.4'
yaml: '>=2.8.3'
postcss: '>=8.5.18' # GHSA-r28c-9q8g-f849
'brace-expansion@2': '>=2.1.3 <3' # GHSA-3jxr-9vmj-r5cp + GHSA-mh99-v99m-4gvg 2.x backport
'brace-expansion@2': '>=2.1.3 <6' # GHSA-3jxr-9vmj-r5cp + GHSA-mh99-v99m-4gvg 2.x backport

@kodus-27b kodus-27b Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug high

Contract violation in the pnpm-workspace.yaml overrides 'brace-expansion@2' entry: widening the bound from '<3' to '<6' moves 2.x consumers up to brace-expansion 5.x. The comment at pnpm-workspace.yaml:58-67 forbids this exact Renovate widening (PR #94). When the lockfile is next re-resolved, minimatch@5.1.9 and minimatch@9.0.9 (pnpm-lock.yaml:4518-4524) pull in 5.x. Its ESM named expand export does not match the 2.x CommonJS default export they import, so glob expansion breaks at runtime. The CI step 'Verify bounded floor-pins stay in-major' (ci.yml:140, 158-166) also expects 'brace-expansion@2 3', finds '6', and fails the security job. Fix: keep the bound at '<3', revert the minimumReleaseAgeExclude entry to 'brace-expansion@2.1.3', and close this Renovate PR; 'brace-expansion@5': '>=5.0.8' already floor-pins the 5.x line.

'brace-expansion@2': '>=2.1.3 <3' # GHSA-3jxr-9vmj-r5cp + GHSA-mh99-v99m-4gvg 2.x backport
Prompt for LLM 

File pnpm-workspace.yaml:

Line 76:

Contract violation in the pnpm-workspace.yaml overrides 'brace-expansion@2' entry: widening the bound from '<3' to '<6' moves 2.x consumers up to brace-expansion 5.x. The comment at pnpm-workspace.yaml:58-67 forbids this exact Renovate widening (PR #94). When the lockfile is next re-resolved, minimatch@5.1.9 and minimatch@9.0.9 (pnpm-lock.yaml:4518-4524) pull in 5.x. Its ESM named `expand` export does not match the 2.x CommonJS default export they import, so glob expansion breaks at runtime. The CI step 'Verify bounded floor-pins stay in-major' (ci.yml:140, 158-166) also expects 'brace-expansion@2 3', finds '6', and fails the security job. Fix: keep the bound at '<3', revert the minimumReleaseAgeExclude entry to 'brace-expansion@2.1.3', and close this Renovate PR; 'brace-expansion@5': '>=5.0.8' already floor-pins the 5.x line.

Suggested Code:

  'brace-expansion@2': '>=2.1.3 <3' # GHSA-3jxr-9vmj-r5cp + GHSA-mh99-v99m-4gvg 2.x backport

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

@kodus-27b kodus-27b Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Kody Rules high

Unexpected transitive major-version jump in the pnpm-workspace.yaml brace-expansion@2 override: the >=2.1.3 <6 range force-resolves packages that declared a 2.x dependency to 3.x, 4.x, or 5.x. This contradicts the trailing '2.x backport' comment and violates Rule 87. A 2.x consumer resolved to brace-expansion 3+ hits its breaking API and ESM changes at runtime. Fix: bound the override to '>=2.1.3 <3', cover 5.x through the existing brace-expansion@5 override, and update the lockfile. If the widening is intentional, attach OSV/audit output and verify each 2.x consumer against 5.x.

Kody rule violation: Validate new/updated dependencies for CVEs and supply-chain risk

Prompt for LLM 

File pnpm-workspace.yaml:

Line 76:

Unexpected transitive major-version jump in the pnpm-workspace.yaml `brace-expansion@2` override: the `>=2.1.3 <6` range force-resolves packages that declared a 2.x dependency to 3.x, 4.x, or 5.x. This contradicts the trailing '2.x backport' comment and violates Rule 87. A 2.x consumer resolved to brace-expansion 3+ hits its breaking API and ESM changes at runtime. Fix: bound the override to `'>=2.1.3 <3'`, cover 5.x through the existing `brace-expansion@5` override, and update the lockfile. If the widening is intentional, attach OSV/audit output and verify each 2.x consumer against 5.x.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

'brace-expansion@5': '>=5.0.8' # GHSA-3jxr-9vmj-r5cp + GHSA-mh99-v99m-4gvg
js-yaml: '>=4.3.0 <5' # GHSA-52cp-r559-cp3m
sharp: '>=0.35.0' # GHSA-f88m-g3jw-g9cj (build denied above; pin is belt+braces)
Expand Down
Loading