Repository navigation
cranelift: avoid clobbering AArch64 stack-limit base on large offsets - #14981
Open
qiyuhuating wants to merge 2 commits into
Open
qiyuhuating wants to merge 2 commits into
qiyuhuating wants to merge 2 commits into
Conversation
github-actions
Bot
added
cranelift
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14946.
Problem
When loading a nested stack_limit global value on AArch64, x16 may hold the base of the next load. Materializing a large offset into x16 destroys that base and yields a bad address or a crash.
Change
Use the reserved x17 temporary for offset materialization when the base register is x16; otherwise retain x16.
Regression coverage
Add a Cranelift .clif run test for nested stack-limit loads with large negative offsets, covering AArch64 and x86_64.
Validation
Not compiled or run locally. Please validate with Cranelift filetests and AArch64 CI before marking ready.