winch(x64): Prefer operands in the value stack for atomic operations - #14074
Merged
alexcrichton merged 1 commit intoAug 3, 2026
Merged
Conversation
This patch fixes bytecodealliance#13989 It passes the arguments of the atomic operations through the value stack instead of calculating and holding the address register prior to handing over control to the MacroAssembler. This approach ensures that spills can happen naturally when specific registers are needed when lowering these operations.
alexcrichton
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes #13989
It passes the arguments of the atomic operations through the value stack instead of calculating and holding the address register prior to handing over control to the MacroAssembler. This approach ensures that spills can happen naturally when specific registers are needed when lowering these operations.