[45.0.x] Fix leak in fd_renumber#13648
Merged
alexcrichton merged 2 commits intoJun 15, 2026
Merged
Conversation
This commit fixes a file descriptor leak in the WASIp1 implementation of `fd_renumber` in the `wasmtime-wasi` crate. Notably the previous implementation did not fully close the file descriptor being renumbered-to which meant that the host's resources for the file, including the file descriptor, stayed alive. The fix here is to validate both fds exist and then delegate to the `fd_close` call to close the destination.
alexcrichton
requested review from
dicej and
fitzgen
and removed request for
a team
dicej
approved these changes
Jun 15, 2026
alexcrichton
merged commit e9fbe97
into
bytecodealliance:release-45.0.0
177 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a file descriptor leak in the WASIp1 implementation of
fd_renumberin thewasmtime-wasicrate. Notably the previousimplementation did not fully close the file descriptor being
renumbered-to which meant that the host's resources for the file,
including the file descriptor, stayed alive. The fix here is to validate
both fds exist and then delegate to the
fd_closecall to close thedestination.
This additionally updates the behavior of
fd_renumberwhen renumberingto fds that weren't previously open to match the
mainbranch whichnotably rejects these calls.