Skip to content

fix(wkg): respect member manifests during fetch - #244

Merged
mkatychev merged 2 commits into
bytecodealliance:mainfrom
subotac:fix/fetch-member-manifest
Aug 3, 2026
Merged

fix(wkg): respect member manifests during fetch#244
mkatychev merged 2 commits into
bytecodealliance:mainfrom
subotac:fix/fetch-member-manifest

Conversation

@subotac

@subotac subotac commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #243.

When wkg fetch ran below a workspace root, it always selected workspace mode even when the current directory had its own wkg.toml. Use the member manifest as the fetch context in that case while preserving
workspace behavior when no local manifest exists.

The regression test verifies that fetching from a member creates the member lock file rather than a workspace lock file.

Testing

  • cargo test -p wkg --test e2e fetch_from_member_manifest_uses_member_context --no-default-features
  • cargo check -p wkg --tests --no-default-features
  • cargo test -p wkg --bin wkg --no-default-features
  • cargo fmt --all -- --check

@subotac
subotac requested a review from mkatychev as a code owner July 30, 2026 17:58
Comment thread crates/wkg/src/wit.rs Outdated
@subotac
subotac requested a review from mkatychev August 2, 2026 21:57

@mkatychev mkatychev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkatychev
mkatychev merged commit 94501bc into bytecodealliance:main Aug 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: wkg fetch will attempt workspace fetching even if a member manifest is present

2 participants