clean(zephyr): reduce warnings on zephyr platform#4860
Merged
lum1n0us merged 2 commits intobytecodealliance:mainfrom Mar 5, 2026
Merged
clean(zephyr): reduce warnings on zephyr platform#4860lum1n0us merged 2 commits intobytecodealliance:mainfrom
lum1n0us merged 2 commits intobytecodealliance:mainfrom
Conversation
buf_len is a long unsigned int, while bytes_* can be negative due to error values. We don't need to check bytes_* for negative value, as it was done during read/write op. Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
kr-t
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
Some platforms, like Zephyr, already define MIN and definition in WAMR cause `warning: "MIN" redefined` warning. Check if it was defined before, and do not redefine it. Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
kr-t
force-pushed
the
fix/reduce-warnings-zephyr
branch
from
07af943 to
e01e6b1
Compare
kr-t
changed the title
lum1n0us
approved these changes
Mar 4, 2026
lum1n0us
added
the
bug-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal changes to reduce warnings on Zephyr's side.
This PR fixes "MIN" redefinition, as well as [-Wsign-compare] warnings.
I recommend we merge this as two separate commits, but it's fine with me if we decide to squash them.
I added explanations both in commit messages and comments.