Draft
Conversation
fibonacci1729
force-pushed
the
compose-semver
branch
2 times, most recently
from
0ad5189 to
ff1db9e
Compare
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
compose-semver
branch
from
ff1db9e to
a0c114b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing issue with wac around composing (or plugging) interfaces that are semver compatible. Previously interface names needed to match exactly ignoring the semver constraints encoded into the interface id. This PR implements a semver compatibility check between interface id to ensure they are on a compatible semver track before merging/composing.
Additionally, type aggregation has been updated to unify and merge interfaces that are semver compatible. Previously it was possible to encode a component that included
foo:bar/baz@0.2.0andfoo:bar/baz@0.2.1. With these updates to type aggregation, these interfaces would be merged intofoo:bar/baz@0.2.1.Note: I made use of GitHub Copilot in implementing this but have written tests and manually verified across a few different examples that this works.