Fix panic in remove_node for Definition nodes#190
Merged
fibonacci1729 merged 3 commits intobytecodealliance:mainfrom Feb 17, 2026
Merged
Fix panic in remove_node for Definition nodes#190fibonacci1729 merged 3 commits intobytecodealliance:mainfrom
fibonacci1729 merged 3 commits intobytecodealliance:mainfrom
Conversation
Definition nodes store their name in the `export` field, not the `name` field (which is None). The log::debug! in remove_node incorrectly used `node.name.as_ref().unwrap()`, which panics for Definition nodes. Changed to `node.export.as_ref().unwrap()`, matching the pattern used elsewhere (e.g., the Display impl at line 1324). Added a unit test that verifies remove_node works correctly for type definition nodes.
fibonacci1729
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportfield, not thenamefield (which isNone)log::debug!inremove_nodeincorrectly usednode.name.as_ref().unwrap(), which panics for Definition nodesnode.export.as_ref().unwrap(), matching the pattern already used in theDisplayimplTest plan
it_can_remove_a_type_definitionthat creates and removes a Definition nodecargo test --workspace)