build: Remove OUT_DIR probe artifact#1628
Open
zertosh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
can_compile()probe artifact fromOUT_DIRat the end of the build script, soOUT_DIRends up empty after the script runs.Where the probe output goes has gone back and forth:
OUT_DIR(-o -) because the emitted.rmetais not byte-reproducible and destabilizes cache keys in build systems that captureOUT_DIRas a build output (e.g. Bazel).-o -made rustc create a temporary metadata directory in the current working directory, which broke sandboxed builds (ChromeOS Portage), so the output moved tostd::env::temp_dir().OUT_DIRfor test compilation output #1526 (2025): writing to the global temp dir left stray files on the host, so the output moved back intoOUT_DIR, which reintroduced the nondeterminism that Don't store build check rmeta #1200 fixed.Writing the probe to
OUT_DIRand deleting it before the script exits satisfies all three constraints: no nondeterministic content left inOUT_DIR, no writes to the working directory, and no clutter in the system temp dir.