bump wasmtime 46.0.0#1230
Merged
Merged
Conversation
jeffcharles
approved these changes
Jun 29, 2026
|
|
||
| let (_, _, fuel_consumed) = run(&mut runner, vec![]); | ||
| assert_fuel_consumed_within_threshold(18_182, fuel_consumed); | ||
| assert_fuel_consumed_within_threshold(18_909, fuel_consumed); |
Member
There was a problem hiding this comment.
Do we have an idea why the increase? Does v46 include any new logic related to fuel calculation?
Member
There was a problem hiding this comment.
I believe this should be related to bytecodealliance/wasmtime#13387
Collaborator
Author
There was a problem hiding this comment.
yeah exactly. I ran a benchmark with those changes disabled and was able to isolate those changes to that issue, heres a benchmark:
empty.wasm
wasmtime 45: 18,182
wasmtime 46 patched: 18,237
wasmtime 46 main: 18,879 +3.83%
fib.wasm
wasmtime 45: 62,358
wasmtime 46 patched: 62,358
wasmtime 46 main: 64,513 +3.46%
text-encoding.wasm
wasmtime 45: 249,691
wasmtime 46 patched: 249,691
wasmtime 46 main: 256,975 +2.92%
saulecabrera
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates wasmtime. I also had to bump the integration test benchmarks because bytecodealliance/wasmtime#13387 added additional fuel consumption that wasn't previously accounted for.
Why am I making this change?
There was a new major version released
Checklist
javy-plugin-apiif the QuickJS bytecode has changed.javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.