Repository navigation
Conversation
This was referenced Nov 4, 2026
Contributor
Author
|
FYI @JosepMariaBlasco I'm trying to cover the testing gap here, let see how deep is the rabbit hole 😅 |
andreaTP
force-pushed
the
wasi-host-fs-tests
branch
from
November 5, 2026 09:25
82fdb22 to
411b5f9
Compare
Contributor
|
Thanks, happy to run our Windows checks against it when it’s ready. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASI testsuite only ran on ZeroFs, so differences of the JDK's default file system on each OS went unnoticed (#274, #280). This also runs it on a JUnit
@TempDirof the host file system.wasi-test-gen-plugingets ahostFileSystemoption that generatesSuiteTestsuiteHostTest, with the same tests as the ZeroFs suite, throughWasiTestRunner.executeOnHost.wasi-testsenables it on JDK 25 and later: older JDKs cannot set file times with nanosecond precision (JDK 11 for files, JDK 17 and 21 for symlinks on Linux), which the testsuite checks.NO_RENAME_DIR_TO_EMPTY_DIRand skipspath_link, as Java does not expose Windows file IDs and hard links get different inode numbers.Fixes found by the new suite:
EIOinstead ofENOTEMPTYon the default file system.O_CREATfailed withEACCESwhen the preopened directory is reached through a symlink, as with/tmpon macOS or the short temp path on Windows.The first commit is #283, needed for the Windows run; it drops out on rebase once #283 is merged.