fix(structured-clone): preserve Blob.type across structuredClone#319
Open
watilde wants to merge 1 commit into
Open
fix(structured-clone): preserve Blob.type across structuredClone#319watilde wants to merge 1 commit into
watilde wants to merge 1 commit into
Conversation
structuredClone(blob) serialized only the byte data and reconstructed
the Blob with an empty type, so structuredClone(new Blob(['x'],
{type: 'text/plain'})).type returned "" instead of "text/plain". A
Blob's type is part of its serialized state per the File API.
Append the type as a length-prefixed UTF-8 string after the byte data
on write, and read it back on read. Add an integration test covering a
typed Blob, an empty type, and content/type round-tripping.
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structuredClone(blob) serialized only the byte data and reconstructed the Blob with an empty type, so structuredClone(new Blob(['x'], {type: 'text/plain'})).type returned "" instead of "text/plain". A Blob's type is part of its serialized state per the File API.
Append the type as a length-prefixed UTF-8 string after the byte data on write, and read it back on read. Add an integration test covering a typed Blob, an empty type, and content/type round-tripping.