fix(form-data): preserve leading BOM in multipart text parts#317
Open
watilde wants to merge 1 commit into
Open
fix(form-data): preserve leading BOM in multipart text parts#317watilde wants to merge 1 commit into
watilde wants to merge 1 commit into
Conversation
Per the Fetch spec, a multipart/form-data part without a filename is decoded with "UTF-8 decode without BOM", which preserves a leading U+FEFF. The parser used encoding_new_decoder_with_bom_removal, which strips it, so "\uFEFFhello" was returned as "hello". Use encoding_new_decoder_without_bom_handling, matching the spec text already quoted in the surrounding comment. Add an integration test. Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the Fetch spec, a multipart/form-data part without a filename is decoded with "UTF-8 decode without BOM", which preserves a leading U+FEFF. The parser used encoding_new_decoder_with_bom_removal, which strips it, so "\uFEFFhello" was returned as "hello".
Use encoding_new_decoder_without_bom_handling, matching the spec text already quoted in the surrounding comment. Add an integration test.