Skip to content

feat: implemented hello command - #268

Open
jmarkerink wants to merge 1 commit into
bwaldvogel:mainfrom
jmarkerink:feat/hello-command
Open

jmarkerink wants to merge 1 commit into
bwaldvogel:mainfrom
jmarkerink:feat/hello-command

Conversation

@jmarkerink

Copy link
Copy Markdown

No description provided.

}

@Test
@Override

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this override?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we test if the real mongo provides more fields, but we 'accept' we have a difference now:

{
  "topologyVersion" : {
    "processId" : id,
    "counter" : 0
  },
  "logicalSessionTimeoutMinutes" : 30,
  "connectionId" : 1,
}

Please share your thoughts, keep it like this or should I add those fields to the implementation.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn’t we rather implement those fields as well in the memory backend?

@jmarkerink jmarkerink Nov 17, 2026 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your change request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants