Repository navigation
feat: implemented hello command - #268
Open
jmarkerink wants to merge 1 commit into
Open
jmarkerink wants to merge 1 commit into
jmarkerink wants to merge 1 commit into
Conversation
bwaldvogel
reviewed
Nov 15, 2026
jmarkerink
force-pushed
the
feat/hello-command
branch
from
November 15, 2026 15:33
990c185 to
baa9531
Compare
bwaldvogel
reviewed
Nov 15, 2026
| } | ||
|
|
||
| @Test | ||
| @Override |
Author
There was a problem hiding this comment.
Now we test if the real mongo provides more fields, but we 'accept' we have a difference now:
{
"topologyVersion" : {
"processId" : id,
"counter" : 0
},
"logicalSessionTimeoutMinutes" : 30,
"connectionId" : 1,
}
Please share your thoughts, keep it like this or should I add those fields to the implementation.
Owner
There was a problem hiding this comment.
Couldn’t we rather implement those fields as well in the memory backend?
Author
There was a problem hiding this comment.
I applied your change request.
jmarkerink
force-pushed
the
feat/hello-command
branch
from
November 17, 2026 19:38
baa9531 to
7a2a07a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.