Repository navigation
Modernize Java code and enforce strict compiler warnings - #265
Merged
Merged
Conversation
Enable -Xlint:all and -Werror for production and test sources in all modules. Leave this-escape disabled until constructor initialization is addressed in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use JDK APIs and language features available with the Java 21 baseline to simplify BSON hex conversion, unsigned byte comparisons, collection handling, type checks, switches, and aggregation parameter classes. Replace concatenated JSON test data with text blocks.
Replace deprecated Netty event-loop APIs and fix the flaky timestamp assertion by making both bounds inclusive.
Enable
-Xlint:alland-Werrorfor production and test sources, with the existing warnings addressed. Keepthis-escapedisabled pending a separate review of constructor initialization.