This repository was archived by the owner on Aug 6, 2021. It is now read-only.
build: Generate TypeScript types from OpenAPI definition#55
Open
firstred wants to merge 6 commits intobunqCommunity:masterfrom
Open
build: Generate TypeScript types from OpenAPI definition#55firstred wants to merge 6 commits intobunqCommunity:masterfrom
firstred wants to merge 6 commits intobunqCommunity:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
===========================================
- Coverage 98.65% 59.38% -39.28%
===========================================
Files 71 17 -54
Lines 2236 517 -1719
Branches 461 96 -365
===========================================
- Hits 2206 307 -1899
- Misses 29 209 +180
Partials 1 1
Continue to review full report at Codecov.
|
flow-danny
referenced
this pull request
Jan 31, 2020
Started implementing oauth support and refactored user type checking
|
Can this be merged? Would very much like to use this 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
This PR will add a script to automatically generate TypeScript types from bunq's OpenAPI definition.
It looks like not all required properties are marked as such in the OpenAPI definition, so there is a way to add these via the script.
To prevent types from being flattened to just primitives such as
string, there is the possibility to extend the definition as well.Generating a new definition file can be done with
yarn build:types. Definitions end up in the filesrc/Types/ApiTypes.tsA backward compatible layer has been added.