Skip to content

build: upgrade Node to 26.13.0 - #52

Merged
brunojppb merged 1 commit into
mainfrom
brunojppb/node-26/upgrade-node-26
Nov 9, 2026
Merged

brunojppb merged 1 commit into
mainfrom
brunojppb/node-26/upgrade-node-26

Conversation

@brunojppb

@brunojppb brunojppb commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

@bufferapp/bufflog is the logging library that Buffer services install. Its CI tests Node 18 and 20 only. Services are moving to Node 26.13.0, and nothing checks that the library works there.

This PR adds 26 to the node-version matrix in .github/workflows/ci.yml. Node 18 and 20 stay, because the library still supports them. package.json has no engines field, and the code needs no change, so I did not add one. The repo has no Dockerfile, .nvmrc or mise.toml. It does not call Corepack and has no native dependency.

I also left @types/node at 18.15.3. It only sets the types the compiler sees, and the build passes with it.

The blast-radius check looked at the CI matrix, engines, @types/node, Dockerfiles, version files, native dependencies and Corepack. Only the matrix needed a change. The runtime risk is pino 5 and pino-http 5 on a new Node. Both work: a clean npm ci, the tsc build and all 15 tests in 2 suites pass under Node 26.13.0.

@brunojppb
brunojppb requested a review from a team as a code owner November 9, 2026 15:27
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • CI now also runs build and test checks with Node.js 26.

The CI build-and-test job now runs with Node.js 26, alongside Node.js 18 and 20.

Suggested reviewers: minac

Merge Risk: Minimal · up to 5a0c5

The change expands CI coverage to Node 26. No merge-blocking risk is established.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "build: upgrade Node to 26.13.0" matches the main change: the CI node-version matrix in .github/workflows/ci.yml gains Node 26 (26.13.0 per the description). The title is short, specific, an…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description matches the changeset. It explains that Node 26.13.0 is added to the CI node-version matrix in .github/workflows/ci.yml while Node 18 and 20 are kept. It also covers the reasons no eng…
Full details: Title check

Explanation

The title "build: upgrade Node to 26.13.0" matches the main change: the CI node-version matrix in .github/workflows/ci.yml gains Node 26 (26.13.0 per the description). The title is short, specific, and follows conventional commit style. It is slightly broader than the change, since the diff only adds Node 26 to the test matrix and keeps Node 18 and 20, so it does not upgrade the Node runtime for the library itself. That gap is minor and does not make the title misleading.

Full details: Description check

Explanation

The description matches the changeset. It explains that Node 26.13.0 is added to the CI node-version matrix in .github/workflows/ci.yml while Node 18 and 20 are kept. It also covers the reasons no engines field, Dockerfile, version file, or @types/node change was needed, and reports the local npm ci, tsc build, and test results under Node 26.13.0. The raw summary confirms the single one-line workflow change.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ac339afc-d918-4bf0-96b9-ba1ddad8c59e
Commits

Reviewing files that changed from the base of the PR and between 749d681 and 5a0c5b6.

Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@brunojppb
brunojppb merged commit d712c1e into main Nov 9, 2026
4 checks passed
@brunojppb
brunojppb deleted the brunojppb/node-26/upgrade-node-26 branch November 9, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant