Repository navigation
build: upgrade Node to 26.13.0 - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bufferapp/bufflogis the logging library that Buffer services install. Its CI tests Node 18 and 20 only. Services are moving to Node 26.13.0, and nothing checks that the library works there.This PR adds 26 to the
node-versionmatrix in.github/workflows/ci.yml. Node 18 and 20 stay, because the library still supports them.package.jsonhas noenginesfield, and the code needs no change, so I did not add one. The repo has no Dockerfile,.nvmrcormise.toml. It does not call Corepack and has no native dependency.I also left
@types/nodeat 18.15.3. It only sets the types the compiler sees, and the build passes with it.The blast-radius check looked at the CI matrix,
engines,@types/node, Dockerfiles, version files, native dependencies and Corepack. Only the matrix needed a change. The runtime risk ispino5 andpino-http5 on a new Node. Both work: a cleannpm ci, thetscbuild and all 15 tests in 2 suites pass under Node 26.13.0.