Repository navigation
Found new managed modules references - #1334
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, | ||
| { | ||
| "name": "2768528c9c73e1988ae1aee8df6faa7c5d8b50bf", | ||
| "digest": "d860a21ab578a2ce6c45908549e2d3abfad0be6e965e04218310a291de7e398559fe8f94e9e02c54cad062d4c3e5c2210a20e8860da372070443736dc29735b9" |
There was a problem hiding this comment.
[Posted at 2026-11-04T12:08:45Z]
Intermediate transition
$ casdiff 813330824839bfdd3abc52f41807095c0de2ec19 \
2768528c9c73e1988ae1aee8df6faa7c5d8b50bf \
--format=markdown1 files changed: 0 removed, 0 renamed, 0 added, 1 changed content.
1 files changed: 0 removed, 0 renamed, 0 added, 1 changed content.
Files changed content:
grpc/service_config/service_config.proto:
--- shake256:975d97de0ded5361b8603cfd422f75053859e146ff9fcea914040bba40ed0bc46954c55d94279e12d9278bff2c87bf846c00df835d72a810d2cbd0b62142839f grpc/service_config/service_config.proto
+++ shake256:3b4e959156eef500c5523479d9917abef79c041f5f3d56b7c81d084cc2dae7aaa3061437d17d6b258aed35808a20f94b7231a7ce0c89ae684b6912bc0eabde36 grpc/service_config/service_config.proto
@@ -254,7 +254,8 @@
google.protobuf.Duration max_ejection_time = 3;
// The maximum % of an address list that can be ejected due to outlier
- // detection. Defaults to 10% but will eject at least one address regardless of the value.
+ // detection. Defaults to 10%. Ejection never takes the ejected percentage
+ // above this value, so a value of 0 disables ejection.
google.protobuf.UInt32Value max_ejection_percent = 4;
// Parameters for the success rate ejection algorithm.
@@ -294,7 +295,7 @@
// some threshold, independently of any other endpoint.
message FailurePercentageEjection {
// The failure percentage to use when determining failure percentage-based outlier detection. If
- // the failure percentage of a given address is greater than or equal to this value, it will be
+ // the failure percentage of a given address is greater than this value, it will be
// ejected. Defaults to 85.
google.protobuf.UInt32Value threshold = 1;
| { | ||
| "module_name": "grpc/grpc", | ||
| "latest_reference": "813330824839bfdd3abc52f41807095c0de2ec19" | ||
| "latest_reference": "2768528c9c73e1988ae1aee8df6faa7c5d8b50bf" |
There was a problem hiding this comment.
[Posted at 2026-11-04T12:08:46Z]
Overall transition
$ casdiff 813330824839bfdd3abc52f41807095c0de2ec19 \
2768528c9c73e1988ae1aee8df6faa7c5d8b50bf \
--format=markdown1 files changed: 0 removed, 0 renamed, 0 added, 1 changed content.
Files changed content:
grpc/service_config/service_config.proto:
--- shake256:975d97de0ded5361b8603cfd422f75053859e146ff9fcea914040bba40ed0bc46954c55d94279e12d9278bff2c87bf846c00df835d72a810d2cbd0b62142839f grpc/service_config/service_config.proto
+++ shake256:3b4e959156eef500c5523479d9917abef79c041f5f3d56b7c81d084cc2dae7aaa3061437d17d6b258aed35808a20f94b7231a7ce0c89ae684b6912bc0eabde36 grpc/service_config/service_config.proto
@@ -254,7 +254,8 @@
google.protobuf.Duration max_ejection_time = 3;
// The maximum % of an address list that can be ejected due to outlier
- // detection. Defaults to 10% but will eject at least one address regardless of the value.
+ // detection. Defaults to 10%. Ejection never takes the ejected percentage
+ // above this value, so a value of 0 disables ejection.
google.protobuf.UInt32Value max_ejection_percent = 4;
// Parameters for the success rate ejection algorithm.
@@ -294,7 +295,7 @@
// some threshold, independently of any other endpoint.
message FailurePercentageEjection {
// The failure percentage to use when determining failure percentage-based outlier detection. If
- // the failure percentage of a given address is greater than or equal to this value, it will be
+ // the failure percentage of a given address is greater than this value, it will be
// ejected. Defaults to 85.
google.protobuf.UInt32Value threshold = 1;
pkwarren
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.