Skip to content

Refactor change_permission method for KVM permission #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RyrieNorth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor change_permission method for KVM permission #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions cli/src/device/emulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,14 @@ def create(self) -> None:

def change_permission(self) -> None:
kvm_path = "/dev/kvm"
if os.path.exists(kvm_path):
cmds = (f"sudo chown 1300:1301 {kvm_path}",
"sudo sed -i '1d' /etc/passwd")
for c in cmds:
subprocess.check_call(c, shell=True)
self.logger.info("KVM permission is granted!")
else:
if not os.path.exists(kvm_path):
raise RuntimeError("/dev/kvm cannot be found!")

subprocess.check_call(
f"sudo chown 1300:1301 {kvm_path}",
shell=True
)
self.logger.info("KVM permission is granted!")

def deploy(self):
self.logger.info(f"Deploying the {self.device_type}")

Expand Down