Add comprehensive tests for critical code paths - #18
Draft
B-BiM wants to merge 2 commits into
Draft
Conversation
Tests cover: - Steel bolt group calculations (40+ tests) * Bolt grid generation and centroid calculation * Brandt instantaneous center method * Complete iterative solution with convergence validation * Physical validity checks - Structural beam analysis (50+ tests) * Polynomial evaluation and piecewise functions * Point load reactions, shear, and moment distributions * Deflection and slope calculations * Load equilibrium validation - Wood stud wall design (60+ tests) * 15+ design factor calculations (Cf, Cm, Ct, Ci, Cb, etc.) * Section property calculations * Deflection limit analysis * Wet service and temperature factor applications Total: 150+ test cases with 370+ assertions Infrastructure: - pytest.ini - Configuration - conftest.py - Shared fixtures and helpers - TEST_IMPLEMENTATION_SUMMARY.md - Complete overview - tests/README.md - Running instructions and coverage details Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document all 150+ tests with detailed breakdown: - 40+ Steel connection tests (bolt group geometry and analysis) - 50+ Beam equation tests (structural analysis fundamentals) - 60+ Wood design tests (factor calculations and properties) Includes: - Critical path analysis for each module - Test statistics and coverage metrics - Running instructions - Maintenance guidelines All critical business logic, data mutation, and physical validity paths are now covered with comprehensive assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
B-BiM
marked this pull request as draft
August 6, 2026 19:06
B-BiM
marked this pull request as ready for review
August 6, 2026 19:25
B-BiM
marked this pull request as draft
August 6, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Add a comprehensive pytest suite to cover the most critical business logic paths: steel connection calculations, beam analysis equations, and wood stud wall design factors. This addresses gaps in automated verification for core calculation and data-mutation logic so regressions are caught early.
What/Approach
Key decisions and notes
How to run
pip install pytest numpy pytest-covpytest tests/ -vpytest tests/ --cov=Analysis --cov=Steel --cov=Wood --cov-report=htmlNotes
Files changed (summary)
Review guidance