Repository navigation
fix: restore fuzzy and Unicode tape search - #365
Merged
Merged
Conversation
yunyv
marked this pull request as ready for review
October 15, 2026 11:34
frostming
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore fuzzy and Unicode matching in
FileTapeStore:This addresses the separate tape-search follow-up described in #361. The current parent filter rejects
deploymntbefore the fuzzy matcher can compare it withdeployment; Unicode is additionally escaped in the text passed to that matcher.Validation
make check: passed all hooks and mypy (57 source files).The full-suite run used a writable temporary
HOMEandOTEL_TRACES_SAMPLER=always_onbecause the execution environment otherwise has a read-only home and an inherited tracing sampler. No application code was changed for those environment constraints.