Annotate directive to avoid issues with minification#18
Open
keathley wants to merge 1 commit intobtford:masterfrom
Open
Annotate directive to avoid issues with minification#18keathley wants to merge 1 commit intobtford:masterfrom
keathley wants to merge 1 commit intobtford:masterfrom
Conversation
|
Thanks for the fix. How does one get this fix into the bower package? |
Author
|
@emwardell This pull request will have to be merged or you can specify my fork with the commit sha in your bower.json file for the time being (that's what I'm currently doing). |
|
@btford Can you please merge this, or one of the other 3 PR's that have been opened to fix this issue? Thanks. |
Author
|
@dave-elkan Since there are 3 open pull requests for the same issue I'm not sure if there's a plan to pull any of them in. In the meantime you can use my fork (or one of the others). |
|
Thanks @spyc3r. I did just that the other day - I was just hoping the author would do his house-keeping as well though. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array syntax is needed to avoid injecting errors after the directive has been minified. This fix should solve those issues. Thanks in advance for any feedback that you have.