Bscholar/nofification#8
Merged
Merged
Conversation
…ents Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Models like `cursor/claude-opus-4-7@1m` and `cursor/claude-opus-4-7@300k` are now collapsed into one `cursor/claude-opus-4-7` entry with a `contextWindow` select option (largest context = default). The TraitsPicker already handles the `contextWindow` descriptor id so no UI changes are needed. Single-variant @-suffix models (e.g. `cursor/claude-sonnet-4-5@200k`) are also collapsed: the base slug is used for display while the full `@variant` slug is kept internally so the Pi CLI receives the correct model identifier. PiAdapter reads the `contextWindow` option selection and appends `@<value>` to the slug before calling `pi --model`, e.g. `cursor/claude-opus-4-7` + selected `1m` → `--model cursor/claude-opus-4-7@1m`.
Single-variant @-suffix models (e.g. cursor/claude-sonnet-4-5@200k)
were constructing the slug as `${v.provider}/${v.model}@${v.variant}`
where v.model already contained the @-suffix, producing a broken
double-@ slug like cursor/claude-sonnet-4-5@200k@200k.
Use `${groupSlug}@${v.variant}` instead so the Pi CLI receives the
correct model identifier, while the display name stays @ -free.
…ules
CI runners install the electron npm package but not the binary, so
electron/index.js throws at load time for any test that transitively
imports an Electron* source file without a vi.mock("electron") guard.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
UI Changes
Checklist