Dead-code sweep from the codebase audit#70
Open
bryanroscoe wants to merge 1 commit into
Open
Conversation
Rust: unused anyhow dependency; SubprocessAdb::from_path/binary/ with_timeout (superseded by raw_transfer); engine AppList struct; RiskTier::parse_label; parse_dumpsys_meminfo demoted to private (parse_total_pss_by_process is the public name). Frontend: riskBadgeClass, unused goto import, four orphaned CSS blocks in the device page (.state-badge variants superseded by the component, .preview-disclaimer, .checkbox-row, .install-output), and .dir-link's undefined --fg token corrected to --fg-primary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit's leftover hygiene items, deferred until the stack landed so nothing could conflict:
anyhowdep; three uncalledSubprocessAdbmethods (from_path/binary/with_timeout— superseded byraw_transfer); the never-usedAppListstruct;RiskTier::parse_label;parse_dumpsys_meminfodemoted to private behind its public alias.riskBadgeClass, an unusedgotoimport, four orphaned CSS blocks in the device page, and.dir-link's undefined--fgtoken →--fg-primary.Pure deletions plus one token fix. Validated: clippy
--all-targets -- -D warningsclean, 149 tests, svelte-check 0/0, build green.