SDK-6821 Phase 3: read apis from the binary's sessionData bucket (flat fallback)#89
Open
anish353 wants to merge 12 commits into
Open
SDK-6821 Phase 3: read apis from the binary's sessionData bucket (flat fallback)#89anish353 wants to merge 12 commits into
anish353 wants to merge 12 commits into
Conversation
…821 Phase 3) The binary is relocating internal fields off session.config into a namespaced sessionData bucket in the StartBinSession/ConnectBinSession echo. Prefer config.sessionData.apis at the single parse site (setConfig serves both RPC paths), falling back to the flat config.apis so the service works against both old and new binaries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
There was a problem hiding this comment.
remove this file from .changeset
Contributor
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
Collaborator
Author
|
RUN_TESTS |
Contributor
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
Bucket-only (the Phase-4 shape the flat fallback cannot mask), bucket-beats-stale-flat, and flat-only (old binary) against the real setConfig. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🔴 SDK PR Review gate is red. Pending:
It turns green once the latest SDK PR Review Agent run reports GTG on the current head commit. A native reviewer approval is separately required by branch protection before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Companion to browserstack-binary#1566 (SDK-6821): the binary relocates internal fields (
apis,capabilityMap,grr_region) offsession.configontosession.internal, and echoes them under a namespacedsessionDatabucket in the StartBinSession/ConnectBinSession config (flat fields retained for backward compat until every SDK migrates).This PR migrates the WDIO service's read: at the single config parse site (
setConfig, which serves BOTH the StartBinSession and ConnectBinSession paths vialoadModules), preferconfig.sessionData.apisand fall back to the flatconfig.apis. All downstream consumers (APIUtils.updateURLSForGRR→ automate/appAutomate/percy/observability/EDS/app-a11y service URLs) are untouched.Backward/forward compatible — works against old binaries (no bucket → flat fallback) and new ones (bucket preferred), so it's independently mergeable. Sibling PRs: node-agent#2335, python-sdk#1162, javaagent#2095, csharp-sdk#1196, ruby-sdk#176.
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
apisservice-URL map from the binary's newconfig.sessionDatabucket (SDK-6821 session.config split), with the flatconfig.apisas backward-compat fallback. Single-point change insetConfig; verifiednpm run buildclean and the vitest suite shows zero new failures vs main (68 pre-existing environmental failures identical on both).Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code