feat(LCAM-1282): central-user test metadata, GRR URL guard, build grouping identifier (v8)#78
Open
ashish0305 wants to merge 2 commits into
Open
feat(LCAM-1282): central-user test metadata, GRR URL guard, build grouping identifier (v8)#78ashish0305 wants to merge 2 commits into
ashish0305 wants to merge 2 commits into
Conversation
…uping identifier Port of ashish0305/webdriveriolc#1 ("support of setting metadata") onto the v8 line of the extracted standalone repo (packages/browserstack-service/src). - Add BrowserStackSDK.setTestMetadata() + TestMetadata store, gated on the app_lcnc central user (BROWSERSTACK_CENTRAL_USER). Metadata is keyed per test-run uuid with a fallback and attached to the TestFramework event and the reporter's BTCER payload. - Emit central-user keys in the TestHub product maps. - APIUtils.updateURLSForGRR: validate the GRR URL set via a hasValidGRRUrls type guard and no-op (return false) when incomplete, preventing the TypeError -> prod-collector fallback. - Send grouping_identifier (BROWSERSTACK_BUILD_GROUPING_IDENTIFIER) on build launch. - Force result='skipped' for TestRunSkipped so downstream status is correct. Existing specs updated for the new app_lcnc product-map key and the onBeforeTest instance arg. Build + full test suite pass locally on v8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7 tasks
ashish0305
marked this pull request as ready for review
July 23, 2026 09:20
ashish0305
requested review from
AakashHotchandani and
dandonarahul2002
and removed request for
a team
July 23, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Adds central-user test-metadata support to the BrowserStack WebdriverIO service on the v8 line, ported from ashish0305/webdriveriolc#1 into this extracted standalone repo (
packages/browserstack-service/src).BrowserStackSDK.setTestMetadata({ identifier, ... })public API backed by a per-test-runTestMetadatastore, gated on theapp_lcnccentral user (BROWSERSTACK_CENTRAL_USER). Metadata is attached to the TestFramework gRPC event and the reporter's BTCER payload.getCentralUser()central-user mode; its keys are merged into the TestHub product maps.APIUtils.updateURLSForGRRvalidates the GRR URL set via ahasValidGRRUrlstype guard and no-ops (returnsfalse) when incomplete — prevents the TypeError → prod-collector fallback.grouping_identifier(BROWSERSTACK_BUILD_GROUPING_IDENTIFIER) on build launch.result = 'skipped'forTestRunSkipped(mocha setsstate = 'pending').Verified locally on v8:
npm run buildpasses and the full test suite is green (42/42 files). Supersedes the accidentally main-based PR #72.Related Jira task/s
LCAM-1282 — App LCA SDK integration (WebdriverIO service, v8). Port of ashish0305/webdriveriolc#1.
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
BrowserStackSDK.setTestMetadata()for central-user integrations.Release notes (internal): (required — engineer-facing; what actually changed / why)
packages/browserstack-service: central-user (app_lcnc) test-metadata store +BrowserStackSDK.setTestMetadata(), central-user keys in the TestHub product maps,hasValidGRRUrlsguard onupdateURLSForGRR,grouping_identifieron build launch, andTestRunSkipped→result='skipped'.testHub/utils,funnelInstrumentation, andtestHubModulespecs for the newapp_lcncproduct-map key /onBeforeTestinstance arg.Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code