Merge fix/SDK-7458-mocha-jasmine-test-tags-v8 - #222
Merged
bsautomation merged 3 commits intoSep 23, 2026
Merged
Conversation
Port of the main-line fix to the v8 branch; the reported build pinned --wdio_versions v8. WDIO Mocha and Jasmine never populated a test-level tags field, so every Observability test arrived with tags == []. @tag tokens in the suite and test titles are the source, matching the node SDK's Jest/Playwright convention. The leading @ is kept so these match Cucumber pickle tags. Both event paths fixed: wdioMochaTestFramework#getTestData now sets KEY_TEST_TAGS (declared in the service's constants, never written, long consumed by the binary), and insights-handler#getRunData now sets tags on TestData. Inert for untagged suites -- a title with no @ token yields []. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Port of the main-line review fixes (#214). - Tag pattern now requires the @ to start a token. /@[\w-]+/g matched any embedded @, so 'user@example.com' produced a bogus @example tag. - reporter.ts#getRunData now sets tags. insights-handler#getRunData is reached only for mocha, so jasmine events and mocha skipped tests went through the reporter, which set scopes but no tags -- the Jasmine claim was false without this. - Doc comment no longer claims node-agent parity; that SDK strips the @. - Tests: embedded-@ cases, plus one per hierarchy shape with scopes omitted, pinned to the order the helper actually returns. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bsautomation
requested review from
pri-gadhiya and
vivianludrick
and removed request for
a team
September 23, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into sdk_v8_pre_prod :by automationbs