fix(color): don't throw on empty computed color (AXE-3861)#268
Open
Aaryan430 wants to merge 1 commit into
Open
fix(color): don't throw on empty computed color (AXE-3861)#268Aaryan430 wants to merge 1 commit into
Aaryan430 wants to merge 1 commit into
Conversation
A detached/inert node (mutation re-scan, or a <template>/shadow subtree) yields an empty computed *-color. colorjs throws "Empty color reference" on it, and that uncaught abort takes down the whole in-page Type-B data collection (and cascades to subsequent Workflow-Analyser steps). Guard parseString: treat a blank/non-string value as transparent instead of throwing. Genuinely-transparent colors (rgba(0,0,0,0)) still parse normally; only empty (== a non-rendered node) is short-circuited, so no element that a rule actually scores changes verdict. Adds parseString specs for empty / whitespace / non-string input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guard
Color.parseStringso a blank / non-string input returns transparent instead of throwing.Why (AXE-3861)
On a
mutationre-scan (SPA) or when walking a<template>/shadow/inert subtree,getComputedStyle(node).getPropertyValue('background-color')returns""for a detached / non-rendered node.colorjs.iothrowsEmpty color referenceon that, whichcolor.jsrethrows asUnable to parse color "". That exception is uncaught in the in-page Type-B collection path (a11y-engine-corecustom-element-handlers), so it aborts the entire Type-B data collection for the page and cascades to subsequent Workflow-Analyser steps.Reproduced end-to-end:
new Colorjs('')→ throwsEmpty color reference;rgba(0,0,0,0)/transparent/ valid colors parse fine.getComputedStyle(detachedNode).getPropertyValue('background-color')→""(attached nodes always return a real value).Historically this signature spans engine
6.3.4→6.4.5across WS / WA / AUT — it's a long-standing latent crash, not a regression.Fix
parseString: blank / non-string → transparent (0,0,0,0), no throw. Tagged// [a11y-rule-color-contrast]:.Accuracy
No element a rule actually scores changes verdict: the guard only fires on empty, and empty only occurs for non-rendered nodes (proven).
color-contrastgates onisVisibleOnScreenbefore reading styles, so it never feeds an empty color to the parser. Genuinely-indeterminate-but-rendered backgrounds (image/gradient/obscured) go through the existingincompleteDatapath and are untouched.Tests
Adds
parseStringspecs for empty / whitespace / non-string. Full color suite passes (59/59) aftergruntbuild.Jira: AXE-3861
🤖 Generated with Claude Code