Skip to content

fix(sdk-go): delete uploaded extension on validation failure (#2725) - #2886

Open
teddiesloco wants to merge 1 commit into
browserbase:mainfrom
teddiesloco:fix/go-sdk-extension-leak
Open

fix(sdk-go): delete uploaded extension on validation failure (#2725)#2886
teddiesloco wants to merge 1 commit into
browserbase:mainfrom
teddiesloco:fix/go-sdk-extension-leak

Conversation

@teddiesloco

@teddiesloco teddiesloco commented Sep 5, 2026

Copy link
Copy Markdown

Summary


Summary by cubic

Fixes orphaned Browserbase extensions accumulating when extension metadata validation fails after a successful upload.

  • The SDK now deletes the uploaded extension best-effort on validation failure when a non-empty extension ID is present.
  • Cleanup uses context.WithoutCancel(ctx), so deletion still runs even if the original request context is canceled.
  • The original validation error is still returned, joined with any cleanup error via errors.Join.

Written for commit 1d9f004. Summary will update on new commits.

Review in cubic

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1d9f004

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

@github-actions github-actions Bot added external-contributor Tracks PRs mirrored from external contributor forks. external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. external-contributor Tracks PRs mirrored from external contributor forks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go SDK leaks an uploaded Browserbase extension when upload-response validation fails

1 participant