test(evals): exercise the workspace V4 CLI - #2838
Draft
shrey150 wants to merge 1 commit into
Draft
Conversation
|
This was referenced Aug 27, 2026
shrey150
force-pushed
the
agent/browse-v4-6-release
branch
from
August 28, 2026 02:52
503061a to
5ec53cb
Compare
This was referenced Aug 28, 2026
shrey150
force-pushed
the
agent/browse-v4-6-release
branch
from
September 11, 2026 17:49
b3a3b41 to
1dd7d0c
Compare
shrey150
force-pushed
the
agent/browse-v4-6-release
branch
from
September 11, 2026 18:23
1dd7d0c to
f8e2579
Compare
Pin eval agents to the V4 workspace CLI, isolate per-run sessions, restrict the wrapper to driver commands, and guarantee cleanup on abort and process shutdown.
shrey150
force-pushed
the
agent/browse-v4-6-release
branch
from
September 11, 2026 20:18
f8e2579 to
f13b62d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make workspace evals and packaging consume the V4 Browse CLI proven in #2835.
The Browse migration changeset now belongs to #2835, the first complete supported-parity head; this PR has no changeset in its own diff. The unrelated eval CLI
--verbosechanges from the old draft are intentionally excluded.Stack (#2872)
--return-xpath; supported V3 parity/release checkpointReview boundary
This is a consumer/integration layer, not another runtime-parity layer. Its diff is limited to eval adapters, their tests, workspace dependency wiring, and the lockfile.
E2E Test Matrix
The current remote PR head is
f13b62d4c17afc55673b82a34ea03622e6eec570. The complete matrix below ran atf8e2579571b5c059753881f14b80abb718066a94; the only inherited change since then is #2849's test-helper timeout diagnostic, whose focused network tests and Browse lint/typecheck passed at sidecar head9887732b6. The product diff is unchanged from proof commit1dd7d0c8ef7ac65697f91780620a417a8ceb6bdd, where the packed-consumer and browser-backed wrapper flows below ran. Browser-backed runs used an isolated daemon directory; the pre-existing default daemon was not touched.f8e257957:pnpm install --frozen-lockfile; buildbrowse; build@browserbasehq/stagehand-evalsf8e257957: full@browserbasehq/stagehand-evalstest suite1dd7d0c8:pnpm --filter browse pack; install the tarball in an empty npm consumer; runnode_modules/.bin/browse --versionandbrowse open --helpworkspace:*to Stagehand4.1.0; installed binary reportedbrowse/0.9.6; V4--remoteand--cdpflags were present.1dd7d0c8: built ESMprepareBrowseCliHarnessAdaptertwicepackages/cli/bin/run.jsat version0.9.6; generated sessions and workdirs were distinct.1dd7d0c8: execute the generated pinned wrapper as a real subprocess:browse open https://example.com, thenbrowse get titleExample Domain.1dd7d0c8: invokebrowse cloud contexts listthrough that wrapper1dd7d0c8: register both live adapter cleanups; cooperative abort; aggressive abort@browserbasehq/stagehand-evalsis private and is intentionally tested as a built workspace consumer, while the publicbrowsepackage is additionally tested as an isolated packed consumer.