union.TagsRLE: Only build if dynamic.Tags is non nil#7145
Open
mattnibs wants to merge 1 commit into
Open
Conversation
mattnibs
force-pushed
the
tags-rle-empty
branch
2 times, most recently
from
July 23, 2026 20:51
8ee31a1 to
4b98ff2
Compare
This commit fixes an issue with union.TagsRLE() which was returning the wrong value on union RLEs with all zeros encoded. Only build RLE if dynamic.Tags is not nil. Closes #7140
nwt
reviewed
Jul 24, 2026
|
|
||
| func (u *Union) TagsRLE() []uint32 { | ||
| if u.rle == nil { | ||
| if u.dynamic.Tags != nil && u.rle == nil { |
Member
There was a problem hiding this comment.
What creates a vector.Union with a nil dynamic.Tags and nil u.rle? Is that something that can happen when the length of the rle is zero?
Collaborator
Author
There was a problem hiding this comment.
An rle with all zeros is nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with union.TagsRLE() which was returning the wrong value on union RLEs with all zeros encoded. Only build RLE if dynamic.Tags is not nil.
Closes #7140