hashjoin: Keep fusion values in output#7144
Merged
Merged
Conversation
This commit changes the hash join operator so that the left and right values are only deunioned and any fusion values are kept intact. It also fixes so hashkey function so hashed values are deunioned beforehand.
mattnibs
commented
Jul 23, 2026
| var fields []super.Field | ||
| if l != nil { | ||
| left := l.Under() | ||
| left := l.Deunion() |
Collaborator
Author
There was a problem hiding this comment.
I question whether we even should be doing a Deunion here but just wanted to keep this change uncontroversial.
nwt
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the hash join operator so that the left and right values are only deunioned and any fusion values are kept intact. It also fixes the hashkey function so hashed values are deunioned beforehand.