vam.defuse: Fix bug with fusion vals in arrays/sets#7030
Open
mattnibs wants to merge 1 commit into
Open
Conversation
If the fusion elements resolves to the same type of another element in the array/set this was resulting in array with duplicate types in its inner union. This commit fixes this by merging same typed vectors after defusing an array or set's inner elements.
nwt
approved these changes
Jun 5, 2026
Comment on lines
+282
to
+283
| # Verify that a defuse on an array/set with a fusion value reset the appropriate | ||
| # inner type. |
Member
There was a problem hiding this comment.
What do you mean by "reset the appropriate inner type"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the fusion elements resolves to the same type of another element in the array/set this was resulting in array with duplicate types in its inner union. This commit fixes this by merging same typed vectors after defusing an array or set's inner elements.