Conversation
mattnibs
requested review from
a team and
philrz
and removed request for
philrz
nwt
reviewed
Mar 27, 2026
vector/array.go
Outdated
| if !ok { | ||
| return val | ||
| } | ||
| switch val := val.(type) { |
Member
There was a problem hiding this comment.
Test coverage or it doesn't work.
Suggested change
| switch val := val.(type) { | |
| switch val := vew.(type) { |
nwt
reviewed
Mar 27, 2026
Comment on lines
+152
to
+154
| f = &anonFunc{sctx, func(sctx *super.Context, vecs ...vector.Any) vector.Any { | ||
| return expr.Unblend(sctx, vecs[0]) | ||
| }} |
Member
There was a problem hiding this comment.
I assume you did this because you plan to use expr.Unblend elsewhere but do we need a new pattern like this? Could you instead following the usual pattern of packaging it as an expr.Function, and then invoke its Call method?
Collaborator
Author
There was a problem hiding this comment.
Yes I'm going to use it with the vectorized json reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.