Skip to content

Fix dangling pointers in NMEA date and time message generation. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bridgecommand merged 1 commit into from
Jul 15, 2025
Merged

Fix dangling pointers in NMEA date and time message generation. #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/NMEA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,13 +381,21 @@ void NMEA::updateNMEA()
std::string dateString = dateTimeString.substr(0, 8);
std::string timeString = dateTimeString.substr(8, 6);

const char *year = dateString.substr(0, 4).c_str();
const char *mon = dateString.substr(4, 2).c_str();
const char *mday = dateString.substr(6, 2).c_str();
std::string yearString = dateString.substr(0, 4);
std::string monthString = dateString.substr(4, 2);
std::string dayString = dateString.substr(6, 2);

const char *hour = timeString.substr(0, 4).c_str();
const char *min = timeString.substr(4, 2).c_str();
const char *sec = timeString.substr(6, 2).c_str();
std::string hourString = timeString.substr(0, 4);
std::string minuteString = timeString.substr(4, 2);
std::string secondsString = timeString.substr(6, 2);

const char *year = yearString.c_str();
const char *mon = monthString.c_str();
const char *mday = dayString.c_str();

const char *hour = hourString.c_str();
const char *min = minuteString.c_str();
const char *sec =secondsString.c_str();

irr::f32 rudderAngle = model->getRudder();

Expand Down