fix: brev ls spinner hanging during onboarding quick tour#348
Draft
hakhandelwal11 wants to merge 1 commit intomainfrom
Draft
fix: brev ls spinner hanging during onboarding quick tour#348hakhandelwal11 wants to merge 1 commit intomainfrom
hakhandelwal11 wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 14.77% 17.69% +2.91%
==========================================
Files 127 140 +13
Lines 16977 18483 +1506
==========================================
+ Hits 2508 3270 +762
- Misses 14182 14853 +671
- Partials 287 360 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After first login, the quick tour asks the user to run brev ls, which starts a spinner waiting for brev shell in another terminal. However, the spinner never stops because it checks HasRunBrevOpen instead of HasRunBrevShell, so the completion condition is never met.
Fix: Changed the condition in
doBrevShellOnboardingfromres.HasRunBrevOpentores.HasRunBrevShellso the spinner correctly detects when brev shell has been run and exits cleanly.