Skip to content

Write deployment packages to the system temp dir instead of .bref/ #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 2 commits into from
Aug 27, 2026
Merged

Write deployment packages to the system temp dir instead of .bref/ #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fda459
Write deployment packages to the system temp dir instead of .bref/
mnapoli Aug 27, 2026
e7b16e6
Drop the legacy .bref/ package cleanup
mnapoli Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions src/Commands/Deploy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,26 +290,32 @@ private function uploadArtifacts(array $config, array $packageUrls): void
->intercept(new SetRequestTimeout(10, 10, $timeout, 60))
->build();

$promises = [];
foreach ($archivePaths as $id => $archivePath) {
$url = $packageUrls[$id];

IO::verbose(sprintf(
'Uploading %s (%d MB)',
$archivePath,
round(((float) filesize($archivePath)) / 1024. / 1024., 1)
));

$request = new Request($url, 'PUT', StreamedContent::fromFile($archivePath));
$promises[] = async(fn() => $client->request($request));
}

try {
await($promises);
} catch (TimeoutException) {
throw new Exception("Timeout while uploading packages after $timeout seconds. This is likely due to a slow network connection");
} catch (Exception $e) {
throw new Exception('Error while uploading packages: ' . $e->getMessage(), 0, $e);
$promises = [];
foreach ($archivePaths as $id => $archivePath) {
$url = $packageUrls[$id];

IO::verbose(sprintf(
'Uploading %s (%d MB)',
$archivePath,
round(((float) filesize($archivePath)) / 1024. / 1024., 1)
));

$request = new Request($url, 'PUT', StreamedContent::fromFile($archivePath));
$promises[] = async(fn() => $client->request($request));
}

try {
await($promises);
} catch (TimeoutException) {
throw new Exception("Timeout while uploading packages after $timeout seconds. This is likely due to a slow network connection");
} catch (Exception $e) {
throw new Exception('Error while uploading packages: ' . $e->getMessage(), 0, $e);
}
} finally {
foreach ($archivePaths as $archivePath) {
@unlink($archivePath);
}
}
}

Expand All @@ -318,10 +324,6 @@ private function uploadArtifacts(array $config, array $packageUrls): void
*/
private function packageArtifact(string $id, string $path, array $patterns): string
{
if (! is_dir('.bref') && ! mkdir('.bref') && ! is_dir('.bref')) {
throw new Exception(sprintf('Directory "%s" could not be created', '.bref'));
}

// Turn the package patterns into regexes
$patternRegexes = [];
foreach ($patterns as $pattern) {
Expand All @@ -335,7 +337,13 @@ private function packageArtifact(string $id, string $path, array $patterns): str
$patternRegexes[$regex] = $include;
}

$archivePath = ".bref/package-$id.zip";
// The archive is written outside the project so that it cannot end up inside another
// deployment package (e.g. a `serverless.yml` deployment of the same project), and it
// is deleted after the upload
$archivePath = tempnam(sys_get_temp_dir(), "bref-package-$id-");
if ($archivePath === false) {
throw new Exception('Could not create a temporary file to package the application');
}

$zip = new ZipArchive;
$zip->open($archivePath, ZipArchive::CREATE | ZipArchive::OVERWRITE);
Expand Down