Skip to content

Preserve falsy request headers like 0 #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Jul 8, 2026
+18 −1
Merged

Preserve falsy request headers like 0 #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Event/Http/Psr7Bridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static function convertRequest(HttpRequestEvent $event, Context $context)
'REQUEST_URI' => $event->getUri(),
'PHP_AUTH_USER' => $user,
'PHP_AUTH_PW' => $password,
]);
], fn ($value) => $value !== null);

foreach ($headers as $name => $values) {
$server['HTTP_' . strtoupper(str_replace('-', '_', (string) $name))] = $values[0];
Expand Down
17 changes: 17 additions & 0 deletions tests/Event/Http/Psr7BridgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,23 @@ public function test I can create a response from a PSR7 response()
], $response->toApiGatewayFormat());
}

public function test falsy server params are not dropped()
{
$event = new HttpRequestEvent([
'httpMethod' => 'GET',
'headers' => [
'Content-Length' => '0',
'Authorization' => 'Basic ' . base64_encode('user:'),
],
]);
$request = Psr7Bridge::convertRequest($event, Context::fake());

$serverParams = $request->getServerParams();
self::assertSame('0', $serverParams['CONTENT_LENGTH']);
self::assertSame('user', $serverParams['PHP_AUTH_USER']);
self::assertSame('', $serverParams['PHP_AUTH_PW']);
}

protected function fromFixture(string $file): void
{
$event = new HttpRequestEvent(json_decode(file_get_contents($file), true, 512, JSON_THROW_ON_ERROR));
Expand Down
Loading