Add management for Recent Connections with profiling and deletion#50
Merged
Conversation
…apabilities - Introduced a "Start Profiling" button for each connection in the Recent Connections panel, allowing users to start profiling directly. - Added a "Delete" button for each connection to remove it from the local database. - Implemented `DeleteRecentConnectionAsync` endpoint in the .NET backend and corresponding TypeScript method in `ProfilerClient`. - Enhanced `ProfilerPanelProvider` with a new method `startProfilingWithConnection` to facilitate automatic profiling start. - Updated UI components in the Recent Connections panel to support new actions and improved styling. - Refactored existing code for consistency and clarity, including logging messages and error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements new features for managing recent connections in the Light Query Profiler extension, most notably adding the ability to delete individual recent connections both in the backend and the VS Code UI. It also introduces a "Start Profiling" button for recent connections, enabling users to quickly begin profiling with a single click. Supporting changes include backend API additions, TypeScript client methods, UI wiring, and comprehensive tests. Minor refactoring for code style consistency (single quotes) is also included.
Recent Connections Management:
DeleteRecentConnectionAsyncJSON-RPC endpoint to the .NET backend, allowing deletion of recent connections by their unique identifier. Includes a request model and robust error handling. [1] [2]deleteRecentConnection(id)method on the TypeScriptProfilerClientfor frontend consumers to trigger deletions. [1] [2]UI/UX Improvements:
startProfilingWithConnection(connection)onProfilerPanelProviderfor programmatic connection and start. [1] [2]Code Quality and Consistency: