Feature/add connection string auth mode#49
Merged
Conversation
- Implemented a new authentication mode allowing users to input a full ADO.NET connection string. - Updated the UI to include a textarea for the connection string input. - Enhanced validation to ensure the connection string is provided when this mode is selected. - Adjusted the connection settings and recent connections models to accommodate the new authentication mode. - Updated tests to cover scenarios for the new connection string mode. - Modified the changelog and README to reflect the new feature.
Normalize connection strings in server when using ConnectionString mode by setting ApplicationName='LightQueryProfiler' before creating ApplicationDbContext. This tags profiler-created SQL connections via client_app_name so ProfilerService.IsProfilerGeneratedEvent can exclude profiler-generated XEvent operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new "Connection String" authentication mode, allowing users to provide a full ADO.NET connection string for SQL Server or Azure SQL Database. The update ensures this mode is handled securely and consistently throughout the backend, including storage, engine detection, and profiling logic. It also updates the documentation to reflect the new authentication method and its availability on both the VS Code Marketplace and Open VSX Registry.
Authentication Mode Enhancements:
Introduced a new
ConnectionStringauthentication mode (AuthenticationMode.ConnectionString), allowing users to connect using a full ADO.NET connection string. The mode is now handled in all relevant backend models and logic, including secure storage and retrieval. [1] [2] [3] [4] [5] [6] [7]Updated the
JsonRpcServerto handle "Connection String" mode: parses and normalizes the connection string, sets the application name, auto-detects the database engine type if needed, and ensures secure handling and storage of the connection string. [1] [2] [3] [4] [5] [6] [7] [8]Database Schema and Migration:
ConnectionStringcolumn if it does not exist. [1] [2]Documentation Updates:
README.mdto document the new "Connection String" authentication mode, including its description in the authentication modes table and instructions for installing the extension from both the VS Code Marketplace and Open VSX Registry. [1] [2] [3] [4]