Skip to content

ci(release): use shared Python publishing actions - #706

Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
mainfrom
abhi-sdk-action
Open

ci(release): use shared Python publishing actions#706
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
mainfrom
abhi-sdk-action

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

Migrate production PyPI releases to the commit-pinned sdk-actions configure, validation, approval, and build-and-ship flow. Enable SBOM attestations while preserving stable approval gating and manual prerelease version overrides.

Migrate production PyPI releases to the commit-pinned sdk-actions configure, validation, approval, and build-and-ship flow. Enable SBOM attestations while preserving stable approval gating and manual prerelease version overrides.

@delner David Elner (delner) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but there's a couple of things worth addressing particularly as it pertains to tooling (and how we update the workflow in the future.) These should be relatively easy fixes. We will need to update repo settings and PyPi to match before we merge this repo.

Comment thread .github/workflows/publish-py-sdk.yaml Outdated
Comment thread .github/workflows/publish-py-sdk.yaml Outdated
Comment thread .github/workflows/publish-py-sdk.yaml Outdated
Comment thread .github/workflows/publish-py-sdk.yaml Outdated
Comment thread docs/publishing.md
@AbhiPrasad

Copy link
Copy Markdown
Member Author

thanks for the review David Elner (@delner)! Pushed up changes in 424ca7f, I also updated environments + pypi publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants