Repository navigation
fix(cursor): improve automatic and manual sdk tracing - #2698
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Conversation
> 🤖 **This text was AI-generated.**
Fix matching for minified ESM/CommonJS builds while preserving automatic/manual
tracing parity. Capture nested tools, reported status/errors, cancellation,
truncation flags, and request IDs. Report cache-inclusive prompt usage without
double-counting.
Before:
```text
Cursor Agent [task]
|-- tool: shell [tool]
`-- tool: task [tool]
`-- Agent: task [task]
(nested tool calls omitted)
```
After:
```text
Cursor Agent [task]
|-- shell [tool]
`-- task [tool]
`-- Cursor Subagent [task]
`-- read [tool]
```
Example for SDK-reported task steps; available detail depends on the SDK.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d46a76b5b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
> 🤖 **This text was AI-generated.**
Keep factory interception on the wrapped surface instead of replacing the
original Agent.create/resume methods. Unwrapped callers and subclasses retain
the SDK's original static dispatch.
Bind public agent methods in place so extracted calls remain private-field
safe while preserving factory promises and their resolved agent identity.
```js
const originalCreate = sdk.Agent.create;
const { Agent } = wrapCursorSDK(sdk);
sdk.Agent.create === originalCreate; // true
const { reload, close } = await Agent.create(options);
await reload(); // retains the agent receiver
close();
```
Call the original prompt implementation without patching its hidden factories.
Automatic hooks still observe internal calls; manual-only prompt capture uses
supplied inputs/options and the final SDK result. Returned Runs retain tool
tracing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we should be in a great place for supporting the new https://cursor.com/blog/agent-sdk
Fix matching for minified ESM/CommonJS builds while preserving automatic/manual tracing parity. Capture nested tools, reported status/errors, cancellation, truncation flags, and request IDs. Report cache-inclusive prompt usage without double-counting.
Before:
After:
Example for SDK-reported task steps; available detail depends on the SDK.