Avoid login during OTEL logger startup by alexr17 · Pull Request #2163 · braintrustdata/braintrust-sdk-javascript

Alex R (alexr17) · 2026-06-24T05:46:37Z

Context

Reduce startup login traffic for mixed OTEL + logger initialization in the JS SDK.

Description

let @braintrust/otel prime internal bootstrap auth for the resolved API key and API URL
let initLogger resolve project metadata directly on that path instead of eagerly calling /api/apikey/login
add focused unit coverage and extend the existing Next.js instrumentation e2e request-flow check

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71f4c8a4d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-24T17:13:08Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d94b2ab51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-24T21:29:15Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a9a2bc2d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-24T22:36:07Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e99deb3c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-25T05:23:34Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d89c5612d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-25T18:06:07Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc78938b10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Alex R (alexr17) · 2026-06-25T19:37:15Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b23d85111

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

This reverts commit f6ac073.

Alex R (alexr17) · 2026-06-29T06:14:05Z

Codex (@codex) review

Alex R (alexr17) · 2026-06-29T06:14:25Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7634009b0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

chatgpt-codex-connector · 2026-06-29T06:20:22Z

+    (!sanitizedApiKey || sanitizedApiKey === otelBootstrapAuth.apiKey) &&
+    matchesLoggedInState;
+
+  if (canUseOtelBootstrap) {


Preserve login state when using bootstrap auth

When this bootstrap branch is taken, the explicit apiKey passed to initLogger is only installed on the background logger connection; the BraintrustState is left without apiUrl, loginToken, orgId, or saved login params. In mixed OTEL/logger setups where the OTEL key matches initLogger({ apiKey }), normal rows upload, but any later path that calls state.login({}) (for example Attachment.upload() during the same flush) will either perform the /api/apikey/login call this path is meant to avoid or fail outright when the key is not also in the environment.

Useful? React with 👍 / 👎.

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread js/src/logger.ts Outdated

Comment thread integrations/otel-js/src/otel.ts

Alex R (alexr17) added the skip-changeset label Jun 24, 2026

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread js/src/logger.ts

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread js/src/logger.ts

Comment thread js/src/logger.ts Outdated

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread e2e/scenarios/claude-agent-sdk-instrumentation/assertions.ts Outdated

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread js/src/logger.ts Outdated

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread js/src/logger.ts Outdated

Comment thread js/src/logger.ts Outdated

Avoid login during OTEL logger startup

1b23d85

Alex R (alexr17) force-pushed the alexr/otel-initlogger-skip-login branch from dc78938 to 1b23d85 Compare June 25, 2026 18:43

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread js/dev/authorize.ts Outdated

Alex R (alexr17) added 4 commits June 25, 2026 13:16

Fix logger startup regressions

8db377e

fix instrumentation guards after realm-safe object checks

f6ac073

Revert "fix instrumentation guards after realm-safe object checks"

72551b2

This reverts commit f6ac073.

Restore function-safe object guards

7634009

chatgpt-codex-connector Bot reviewed Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

Alex R (alexr17) commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Description

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Alex R (alexr17) commented Jun 29, 2026

Uh oh!

Alex R (alexr17) commented Jun 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Alex R (alexr17) commented Jun 24, 2026 •

edited

Loading