Repository navigation
ref(codex): add plugin submission review cases - #251
Conversation
> 🤖 **This text was AI-generated.** The Braintrust MCP package lacked the reviewer scenarios requested by OpenAI's submission guidance: https://developers.openai.com/plugins/deploy/submission#testing Add five positive cases with expected tools and results, plus three negative cases with reasons and safe fallbacks. Validate their structure and preserve them in the submission ZIP. ```text before: com.openai.interface after: com.openai.interface + review.test_cases |-- positive: 5 scenarios `-- negative: 3 scenarios ``` The scenarios still need to be run with a dedicated review account before submission.
Abhijeet Prasad (AbhiPrasad)
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ab940bf0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| "review": { | ||
| "test_cases": { |
There was a problem hiding this comment.
When this ZIP is uploaded for OpenAI review, the submission workflow requests these positive and negative cases as form inputs; it does not read a com.openai.review.test_cases plugin-manifest extension. Consequently, preserving this invented field in plugin.json does not populate the reviewer scenarios and may make the uploaded manifest fail strict extension validation, leaving the submission blocked despite the local tests passing. Store the cases in submission documentation or automation that populates the documented review form rather than in the deployed manifest.
Useful? React with 👍 / 👎.
The Braintrust MCP package lacked the reviewer scenarios requested by OpenAI's submission guidance:
https://developers.openai.com/plugins/deploy/submission#testing
Add five positive cases with expected tools and results, plus three negative cases with reasons and safe fallbacks. Validate their structure and preserve them in the submission ZIP.
The scenarios still need to be run with a dedicated review account before submission.