Fix error on unknown recommendation values - #139
Open
francisco-guemes wants to merge 2 commits into
Open
francisco-guemes wants to merge 2 commits into
francisco-guemes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the robustness of the
CustomerRecommendationsPayloadclass by adding error handling and logging for parsing payment recommendations. The main changes ensure that invalid or missing payment recommendations are gracefully skipped and logged, preventing potential runtime errors.At the moment if the response from Braintree BE contains values that can not be mapped by the enum
RecommendedPaymentOptionit throws aServerExceptioncausing to stop the parsing for all payment recommendations.Error handling and logging improvements
Loggerto the class and now log warnings when encountering payment recommendations with missing or unknown payment options. [1] [2]parsePaymentRecommendationandparsePaymentOptionhelper methods, which validate input and handle exceptions, returningnullfor invalid entries.nullpayment recommendations, ensuring only valid recommendations are processed.These changes make the code more resilient to malformed data and improve observability for debugging issues related to payment recommendations.
Checklist
rake test:unit) -->TZ=UTC mvn testthere is test that is sensitive to timezone