Skip to content

Fix: sets cmake build type to Release in case it is empty #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrey1994 merged 2 commits into from
Aug 2, 2026
+7 −19
Merged

Fix: sets cmake build type to Release in case it is empty #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4af52d
Fix: sets cmake build type to Release in case it is empty
rrajrao Jul 16, 2026
d68436c
Remove libftdi from Android workflow
Andrey1994 Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions .github/workflows/run_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,30 +38,12 @@ jobs:
echo "y" | sudo -H ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager --install "ndk;${ANDROID_NDK_VERSION}" "platforms;${ANDROID_API_LEVEL}" --sdk_root=${ANDROID_SDK_ROOT}
env:
DEBIAN_FRONTEND: noninteractive
# build for all ABIs
- name: Compile libusb
run: |
git clone --depth 1 --branch android https://github.com/xloem/libusb.git
cd libusb/android/jni
${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/ndk-build
- name: Compile libftdi
run: |
git clone --depth 1 --branch v1.5 git://developer.intra2net.com/libftdi
cd libftdi
git checkout 5c2c58e03ea999534e8cb64906c8ae8b15536c30 # tip of v1.5
for ABI in arm64-v8a armeabi-v7a x86 x86_64; do
mkdir $GITHUB_WORKSPACE/libftdi/build-$ABI
cd $GITHUB_WORKSPACE/libftdi/build-$ABI
cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} -DEXAMPLES=OFF -DFTDI_EEPROM=OFF -DLIBUSB_LIBRARIES=$GITHUB_WORKSPACE/libusb/android/libs/$ABI/libusb1.0.so -DLIBUSB_INCLUDE_DIR=$GITHUB_WORKSPACE/libusb/libusb -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install-$ABI ..
ninja
ninja install
done
- name: Compile BrainFlow
run: |
for ABI in arm64-v8a armeabi-v7a x86 x86_64; do
mkdir $GITHUB_WORKSPACE/build-$ABI
cd $GITHUB_WORKSPACE/build-$ABI
cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} -DCMAKE_FIND_ROOT_PATH=$GITHUB_WORKSPACE/install-$ABI -DUSE_LIBFTDI=ON ..
cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${ANDROID_NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=$ABI -DCMAKE_BUILD_TYPE=Release -DANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL} ..
ninja
done
- name: Build Android AAR
Expand Down
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ cmake_minimum_required (VERSION 3.13)

project (brainflow)


if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Default build type" FORCE)
endif()


SET (CMAKE_CXX_STANDARD 11)
SET (CMAKE_VERBOSE_MAKEFILE ON)
SET (BRAINFLOW_VERSION "0.0.1" CACHE STRING "BrainFlow Version")
Expand Down
Loading