Fix: owner/repo shorthand rejected when input has a trailing slash - #104
Fix: owner/repo shorthand rejected when input has a trailing slash#104nakulsharma97 wants to merge 1 commit into
Conversation
|
@nakulsharma97 is attempting to deploy a commit to the braedonsaunders' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks. The trailing-slash parseUrl fix looks good, and the new tests help. This PR also brings Windows CLI watcher changes, analysis.js tweaks, pattern filtering, and a |
parseUrl() now accepts a trailing slash on both the bare owner/repo shorthand (e.g. "facebook/react/") and full GitHub URLs (e.g. https://github.com/facebook/react/). Added tests covering trailing-slash acceptance, extra-segment rejection, .git suffix stripping, and garbage input. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
d10836e to
dc23570
Compare
|
Done — scoped the PR to the parseUrl fix only. All unrelated files (CLI watcher, analysis.js tweaks, pattern filtering, What changed:
The Windows CLI watcher fixes and cross-platform test improvements can go in a separate PR whenever you're ready to review them. |
|
Perfect, thanks for scoping it. The parseUrl change and the new tests look good. I approved CI on the latest commit; will merge once Codex and checks are through. Separate PR for the Windows watcher whenever you're ready. |
braedonsaunders
left a comment
braedonsaunders
left a comment
There was a problem hiding this comment.
Looks good. Trailing-slash on bare owner/repo is the right fix, and the new parse-url tests cover the cases I care about. CI green on Tests and CodeQL. Holding the merge until Codex can review the latest commit (usage limits right now), then I will merge. Windows CLI watcher still welcome as a separate PR.
2 participants
No description provided.