feat(content-uploader): add support for item share button and open preview button#4624
feat(content-uploader): add support for item share button and open preview button#4624Omfalos wants to merge 1 commit into
Conversation
|
Karol Machulski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughContentUploader adds two new optional callback props— ChangesModernized Uploads Callback Props
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed due to a network error. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| onMinimize?: () => void; | ||
| onProgress: (item: UploadItem) => void; | ||
| onResume: (item: UploadItem) => void; | ||
| onItemShare: (itemId: string) => void; |
There was a problem hiding this comment.
Shouldn’t these be optional? If I’m understanding correctly, the old UploadsManager doesn’t support them.
There was a problem hiding this comment.
Yes, we should make them optional
Add support to two new callbacks added to the uploads manager that where not passed from wrapping component
They enable to perform action connected to share and to opening in new tab
Summary by CodeRabbit
Release Notes
New Features
Tests